fix(material/chips): add opt-out for single-select checkmarks #26338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
zarend
requested review from
andrewseguin,
crisbeto and
mmalerba
as code owners
zarend
force-pushed
the
chips-opt-out
branch
2 times, most recently
from
bfd2910 to
fe8b637
Compare
Contributor
Author
|
Changes since this was last reviewed
|
Add an opt-out for checkmark indicators for single-selection. Add both and Input and DI token to specify if checkmark indicators are hidden for single-select. By default display checkmark indicators for single-selection. If both DI token and Input are specified, the Input wins. PR angular#25890 adds checkmork indicator for single selection. Add an opt-out to provide a way to have same appearance as before angular#25890. Does not affect multiple-selection. Does not affect behavior when avatar is provided. When avatar is provided, display checkmark indicator when selected. This is the same behavior as before angular#25890. API Changes - Add `@Input hideSingleSelectionIndicator` to specify if checkmark indicator is displayed for single-selection - Add `hideSingleSelectionIndicator` property to `MatChipsDefaultOptions`, which specifies default value for `hideSingleSelectionIndicator`.
crisbeto
approved these changes
Jan 4, 2023
zarend
added a commit
to zarend/components
that referenced
this pull request
Jan 5, 2023
Update the accessibility section on checkmark indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for angular#25890 and angular#26338.
zarend
added a commit
to zarend/components
that referenced
this pull request
Jan 9, 2023
Update the accessibility section on checkmark indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for angular#25890 and angular#26338.
zarend
added a commit
to zarend/components
that referenced
this pull request
Jan 9, 2023
Update the accessibility section on checkmark indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for angular#25890 and angular#26338.
zarend
added a commit
to zarend/components
that referenced
this pull request
Jan 9, 2023
Update the accessibility section on checkmark indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for angular#25890 and angular#26338.
zarend
added a commit
to zarend/components
that referenced
this pull request
Jan 10, 2023
Update the accessibility section on checkmark indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for angular#25890 and angular#26338.
zarend
added a commit
to zarend/components
that referenced
this pull request
Jan 10, 2023
Update the accessibility section on checkmark indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for angular#25890 and angular#26338.
zarend
added a commit
to zarend/components
that referenced
this pull request
Jan 10, 2023
Update the accessibility section on checkmark indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for angular#25890 and angular#26338.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an opt-out for checkmark indicators for single-selection. Add both and Input and DI token to specify if checkmark indicators are hidden for single-select. By default display checkmark indicators for single-selection. If both DI token and Input are specified, the Input wins.
PR #25890 adds checkmork indicator for single selection. Add an opt-out to provide a way to have same appearance as before #25890.
Does not affect multiple-selection.
Does not affect behavior when avatar is provided. When avatar is provided, display checkmark indicator when selected. This is the same behavior as before #25890.
API Changes
@Input hideSingleSelectionIndicatorto specify if checkmark indicator is displayed for single-selectionhideSingleSelectionIndicatorproperty toMatChipsDefaultOptions, which specifies default value forhideSingleSelectionIndicator.